https://github.com/X11Libre/xserver/pull/56

metux doesn't know that ^ is xor in C? amazing.

@ariadne I made this mistake when I first learned C. Then again my first programming-ish language was Macsyma!

@tavianator that's my point. do we want to give effective root access to someone who makes such rookie mistakes?

@ariadne

If we ever have conference

ahahahaha

@kate i thought the klan was constantly having conferences

@ariadne and there are actually people saying the "quality of xlibre is better"

@ariadne looking at the change that introduced this bug I think I understand why the x devs told him to fuck off, before he went mask off
https://github.com/dec05eba/xserver/commit/a8f0e2801e606cd48832a1d208b9f5a3499c48a8#diff-f71de6fd48a8c7d1a0e55e67c8c69014a9a153c4b8a3082460640fb3686e52c7R271

@ariadne
(Important context: xcallocarray is a function that exists)

https://github.com/dec05eba/xserver/blob/5c0463a04f64c2040fa8fa66cf95b31369a879c7/os/alloc.c#L33

@Mae @ariadne oh god this looks like baby’s first venture into C memory management. i’m actually impressed because I don’t consider myself proficient at it but i wouldn’t spew bullshit like that commit message

@ariadne It really feels like he doesn't test his code.

@domi @ariadne I don't consider myself a C expert, but if a junior came to me with this commit I'd be delighted to teach them

This guy wants to maintain x11

@Mae @ariadne i wouldn’t even consider myself a C junior, just someone who occasionally dabbles in it for fun, and I’m appalled at both of those issues.

(inb4 impostor syndrome)

@ariadne
Every minute these awful assholes waste on this project is a minute not spent doing something worse at least. Maybe they could also chop up mastodon to make something worse... oh wait.

@sb truth social already exists 😂

@Mae anyone maintaining something like X should understand why reallocarray()-type functions are necessary...

@Mae @ariadne As well as the xor/power mix up, it seems to be mistaking an array of listening sockets for an array of connections.

If the change had successfully limited the server to 18 connections, they might have caught the bug. Instead, you'd probably need to pass 19 -listenfd arguments to the server to trigger the added error.